Make some log lines report at DEBUG level #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
force-pushed
the
hs/logging-improvement
branch
from
5c85b12 to
72d6897
Compare
|
Reminder to myself that "Server doesn't mirror parts" should not be logged for each room. |
|
Also log eventIds, not messages. |
jaller94
reviewed
Nov 20, 2020
| req.log.info("onPrivateMessage: %s from=%s to=%s action=%s", | ||
| server.domain, fromUser, toUser, | ||
| JSON.stringify(action).substring(0, 80) | ||
| req.log.info("onPrivateMessage: %s from=%s to=%s", |
There was a problem hiding this comment.
What's the reasoning to keep these on info?
There was a problem hiding this comment.
It's still really useful to keep track of when people perform actions, the info level just strips away the message data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1167