MediaProxy Not Working

[voice06]

Tried setting up the new MediaProxy but it appears I can only get it as far as pinging my Synapse server, at that point it appears MediaProxy / matrix-bot-sdk is hard coded to use the old unauthenticated method resulting in a 404 returned to MediaProxy.

2024-09-04 09:15:27 ERROR:main TypeError [ERR_HTTP_INVALID_HEADER_VALUE]: Invalid value "undefined" for header "content-disposition"
at ServerResponse.setHeader (node:_http_outgoing:662:3)
at ClientRequest. (/home/matrixserv/matrix-appservice-irc/node_modules/matrix-appservice-bridge/lib/components/media-proxy.js:151:17)
at Object.onceWrapper (node:events:634:26)
at ClientRequest.emit (node:events:519:28)
at ClientRequest.emit (node:domain:488:12)
at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:698:27)
at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17)
at Socket.socketOnData (node:_http_client:540:22)
at Socket.emit (node:events:519:28)
at Socket.emit (node:domain:488:12)
at addChunk (node:internal/streams/readable:559:12)
at readableAddChunkPushByteMode (node:internal/streams/readable:510:3)
at Readable.push (node:internal/streams/readable:390:5)
at TCP.onStreamRead (node:internal/stream_base_commons:191:23)
2024-09-04 09:15:27 ERROR:main Terminating (exitcode=1)

2024-09-04 09:15:27,523 - synapse.http.server - 130 - INFO - GET-2998 - <XForwardedForRequest at 0x7f9af82a2f10 method='GET' uri='/_matrix/media/v3/download/randomsonicnet.org/aslVYQQXqxHqirkfqNLkcvdh' clientproto='HTTP/1.1' site='8449'> SynapseError: 404 - Not found

https://github.com/matrix-org/matrix-appservice-bridge/blob/develop/src/components/media-proxy.ts#L150
https://github.com/turt2live/matrix-bot-sdk/blob/main/src/MatrixClient.ts#L1580

[Half-Shot]

Thanks for the report, we've identified this and will have a fix ready to go this week.

[tadzik]

Should be all good on 3.0.1 – thanks for your report!