Add some missing periods. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is something we should adhere to then please write it into the contributing guide for this repo |
Good point: c438b8c |
bmarty
added a commit
to element-hq/element-android
that referenced
this pull request
May 16, 2022
Will require matrix-org/matrix-analytics-events#63 for long term solution
4 tasks
pixlwave
approved these changes
May 20, 2022
|
One question, how come only the Kotlin files are updated? |
My bad, I am calling c1e0c1a contains all the generated files. |
|
LGTM 👌 |
ouchadam
approved these changes
May 23, 2022
piersonleo
pushed a commit
to piersonleo/element-android
that referenced
this pull request
Jun 7, 2022
Will require matrix-org/matrix-analytics-events#63 for long term solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated code is analyzed by Detekt when imported in the Element Android project, and the Kdoc content is (or rather will be) checked. Sentences have to end with a period.