Split comment in generated kotlin files. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
added a commit
to element-hq/element-android
that referenced
this pull request
Jan 20, 2022
pixlwave
approved these changes
Jan 21, 2022
onurays
added a commit
to element-hq/element-android
that referenced
this pull request
Jan 23, 2022
* develop: (66 commits) toolbar management (#4887) adding changelog entry adding back periodic flag when scheduling automatic background workers Fix enum class warning Split long lines Done by matrix-org/matrix-analytics-events#16 Add new class in analytics plan Fix conditional for Delight issue automation Add missing import in kdoc Update kdoc Enable Delight issue automation Fix an error in string resource (#4997) Changelog Add some unit test for the command parser. Not all commands are covered, could add more tests later. data class. use sealed interface Small cleanup Command parser is not a static object anymore Add changelog Use Throwable.isLimitExceededError extension Do not automatically retry 429 with a too long delay ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We import the generated Kotlin files to the Element Android project and our CI does not like long lines (me neither - that why I set up the CI like this!)
@pixlwave @novocaine not sure it's relevant to do the same for iOS / js generated files.
Happy to do it if you want me to, just let me know.