This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
Don't return error when account conflict is handled gracefully #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianathere
pushed a commit
to HereNotThere/dendrite
that referenced
this pull request
Mar 29, 2023
- Updates the SpaceOwner NFT to TownOwner, which uses a better ERC721Base standard - Updates the SpaceFactory with a setSpaceToken function which updates the NFT minted on space creation. - Renames SpaceOwner imports to TownOwner in contracts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect this will be sufficient to fix #1780. I've tested it locally with SQLite and it still successfully handles duplicate account registration properly.