Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Docker fix and tweak #1781

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Docker fix and tweak #1781

merged 2 commits into from
Mar 3, 2021

Conversation

stoically
Copy link
Contributor

@stoically stoically commented Mar 3, 2021 •
edited
Loading

  • Recent docker versions want a trailing slash on the target when COPYing multiple files
  • Default docker dendrite-config.yaml points to /var/dendrite/media as media storage path, which isn't mounted and can easily result in data loss (happened to me)

Pull Request Checklist

  • I have added any new tests that need to pass to sytest-whitelist as specified in docs/sytest.md
  • Pull request includes a sign off

Signed-off-by: stoically <[email protected]>

neilalexander
neilalexander approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thanks for this!

@neilalexander neilalexander merged commit 41fd15b into matrix-org:master Mar 3, 2021
@stoically stoically deleted the refactor/docker-tweaks branch March 3, 2021 12:20
@matrixbot matrixbot mentioned this pull request Nov 1, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoically @neilalexander