Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Fix SQLite registration bug #1777

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Fix SQLite registration bug #1777

merged 1 commit into from
Mar 2, 2021

Conversation

neilalexander
Copy link
Contributor

This fixes two things:

  • The error type returned by SQLite on a violated constraint wasn't triggering the upstream code to check for duplicate accounts, causing the registration flow to proceed unexpectedly
  • The order of insertions on an account creation has been changed to try the account insertion before the account data/profile

@neilalexander neilalexander requested a review from kegsay March 2, 2021 10:23
kegsay added a commit to matrix-org/complement that referenced this pull request Mar 2, 2021
Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for CI but this LGTM. This does mean that duplication /register requests for the same user will now fail even if the login credentials are correct, but this is probably fine since the client should be using /login.

@neilalexander
Copy link
Contributor Author

The sytest failure Local device key changes get to remote servers with correct prev_id is about to be blacklisted in a separate PR, the other tests are green.

@neilalexander neilalexander merged commit f5cf241 into master Mar 2, 2021
@neilalexander neilalexander deleted the neilalexander/regfix branch March 2, 2021 10:43
kegsay added a commit to matrix-org/complement that referenced this pull request Mar 2, 2021
* Add registration regression test for matrix-org/dendrite#1777

* Response should be 400
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants