Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Implement cross-signing keys #1312

Closed
kegsay opened this issue Aug 24, 2020 · 1 comment
Closed

Implement cross-signing keys #1312

kegsay opened this issue Aug 24, 2020 · 1 comment
Assignees
@kegsay
Labels
are-we-synapse-yet This issue or PR involves Sytests in AWSY spec-divergence This issue or PR diverges from the spec

Comments

@kegsay
Copy link
Member

kegsay commented Aug 24, 2020

Sytests:

    × Can upload self-signing keys
    × Fails to upload self-signing keys with no auth
    × Fails to upload self-signing key without master key
    × Changing master key notifies local users
    × Changing user-signing key notifies local users
    × can fetch self-signing keys over federation
    × uploading self-signing key notifies over federation
    × uploading signed devices gets propagated over federation
@kegsay kegsay added spec-divergence This issue or PR diverges from the spec are-we-synapse-yet This issue or PR involves Sytests in AWSY labels Aug 24, 2020
@neilalexander neilalexander self-assigned this Jul 28, 2021
neilalexander added a commit to matrix-org/gomatrixserverlib that referenced this issue Jul 28, 2021
@neilalexander
Define cross-signing types (matrix-org/dendrite#1312)
a268856
neilalexander added a commit to matrix-org/gomatrixserverlib that referenced this issue Aug 2, 2021
@neilalexander
Cross-signing types, Base64Types updates (#274)
d68dd72 
* Define cross-signing types (matrix-org/dendrite#1312)

* Exclude signatures key if empty

* Define purpose consts

* Scan for Base64Bytes

* Conform to sql.Valuer interface too

* Without pointer receiver

* Remove unuseful types

* CrossSigningForKeyOrDevice

* Base64Bytes from RawJSON

* Extend RespQueryKeys

* Fix type

* Fix CrossSigningFrorKeyOrDevice unmarshaller

* Update types

* Update types in RespUserDeviceKeys

* Review comments
@kegsay kegsay assigned kegsay and unassigned neilalexander Jan 21, 2022
@S7evinK
Copy link
Contributor

S7evinK commented Feb 9, 2022

All tests should be passing now.

  Cross-signing Keys       : 100% (8/8 tests)
    ✓ Can upload self-signing keys
    ✓ Fails to upload self-signing keys with no auth
    ✓ Fails to upload self-signing key without master key
    ✓ Changing master key notifies local users
    ✓ Changing user-signing key notifies local users
    ✓ can fetch self-signing keys over federation
    ✓ uploading self-signing key notifies over federation
    ✓ uploading signed devices gets propagated over federation

@S7evinK S7evinK closed this as completed Feb 9, 2022
@matrixbot matrixbot mentioned this issue Oct 31, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kegsay kegsay

Labels
are-we-synapse-yet This issue or PR involves Sytests in AWSY spec-divergence This issue or PR diverges from the spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neilalexander @S7evinK @kegsay