Add more logging and errors #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
approved these changes
Nov 13, 2023
src/commands/actions/roles.ts
Outdated
| @@ -27,7 +27,7 @@ export async function runRoleCommand(action: IAction, conference: Conference, cl | |||
| const aud = backstageOnly ? conference.getAuditoriumBackstage(args[0]) : conference.getAuditorium(args[0]); | |||
| if (!aud) { | |||
| const spiRoom = conference.getInterestRoom(args[0]); | |||
| if (!spiRoom) return client.replyNotice(roomId, event, "Unknown auditorium/interest room"); | |||
| if (!spiRoom) return client.replyNotice(roomId, event, `Unknown auditorium/interest room: ${spiRoom}`); | |||
There was a problem hiding this comment.
spiRoom would always be falsey here, so the error message probably doesn't need to include it?
There was a problem hiding this comment.
Ah good catch - I got a little overzealous there :)
|
Merged #197 into main, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the mission to improve command errors. Adds more errors to:
FDMCommand
InviteCommand
InviteMeCommand
JoinRoomCommand
PermissionsCommand