Add more specific errors to CopyModerators command
#196
Conversation
| @@ -61,7 +61,7 @@ export class HelpCommand implements ICommand { | |||
| "<pre><code>" + | |||
| "!conference inviteme <room> - Asks the bot to invite you to the given room.\n" + | |||
| "!conference inviteto <room> <user> - Asks the bot to invite the given user to the given room.\n" + | |||
| "!conference join <room> - Makes the bot join the given room.\n" | |||
| "!conference join <room> - Makes the bot join the given room.\n" + | |||
There was a problem hiding this comment.
This was just a typo I noticed that was causing the last two help commands to not be shown in the client. Drive-by cleanup.
There was a problem hiding this comment.
I hate how JavaScript is happy to have these implied semicolons lead to effectively empty / ignored statements. Thanks for catching it :-)
| const fromPl: {"users"?: Record<string, any>} = await this.client.getRoomStateEvent(fromRoomId, "m.room.power_levels", ""); | ||
| let toPl = await this.client.getRoomStateEvent(toRoomId, "m.room.power_levels", ""); | ||
|
|
||
| let fromPl: { "users"?: Record<string, any> } = {} |
There was a problem hiding this comment.
PowerLevelsEventContent may also work here?
There was a problem hiding this comment.
It does - much nicer, thanks!
|
|
||
| try { | ||
| var toPl = await this.client.getRoomStateEvent(toRoomId, "m.room.power_levels", ""); |
There was a problem hiding this comment.
| try { | |
| var toPl = await this.client.getRoomStateEvent(toRoomId, "m.room.power_levels", ""); | |
| let toPl: PowerLevelsEventContent; | |
| try { | |
| toPl = await this.client.getRoomStateEvent(toRoomId, "m.room.power_levels", ""); |
Avoid using var if you can, it doesn't conform to block scoping and tends to surprise you. In this case TypeScript should let you define toPl outside and it will always be set, because you are throwing.
|
Merged #196 into main, thanks for the review! |
Part of the effort to improve error messages. I hate that it is a pile of try/catch but I wasn't sure how else to give more specific information about where things are failing. Suggestions welcome.