Remove field ITalk.track (#239)

Since now tracks == auditoria, there is no need for having this extra datapoint (which ultimately could lead to more confusion than good)
matrix-org · Dec 17, 2024 · b30a57a · b30a57a
1 parent a7583ca
commit b30a57a
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 24 deletions.
diff --git a/src/Scheduler.ts b/src/Scheduler.ts
@@ -379,18 +379,6 @@ export class Scheduler {
                 (task.talk.qa_startTime !== null ? `<p>During the talk, you can ask questions here for the Q&A at the end. ` +
                 `The questions with the most 👍 votes are most visible to the speaker.</p>` : ''),
             );
-
-            try {
-                if (task.talk.track != '' && task.talk.track != undefined) {
-                    const nameEventContent = await this.client.getRoomStateEvent(confAud.roomId, "m.room.name", "");
-                    if (task.talk.track != nameEventContent["name"]) {
-                        nameEventContent["name"] = task.talk.track;
-                        await this.client.sendStateEvent(confAud.roomId, "m.room.name", "", nameEventContent);
-                    }
-                }
-            } catch (e) {
-                LogService.error("Scheduler:talkStart", `Error when considering changing name of track room`, e);
-            }
         } else if (task.type === ScheduledTaskType.TalkQA) {
             if (!task.talk.prerecorded) return;
             if (confTalk !== undefined) {

diff --git a/src/__tests__/backends/penta/__snapshots__/PentabarfParser.test.ts.snap b/src/__tests__/backends/penta/__snapshots__/PentabarfParser.test.ts.snap
@@ -38,7 +38,6 @@ exports[`parsing pentabarf XML: overview: auditoriums 1`] = `
         "startTime": 1675501200000,
         "subtitle": "",
         "title": "Testcon01: Opening Remarks",
-        "track": "Track01",
       },
     },
   },
@@ -84,7 +83,6 @@ exports[`parsing pentabarf XML: overview: conference 1`] = `
           "startTime": 1675501200000,
           "subtitle": "",
           "title": "Testcon01: Opening Remarks",
-          "track": "Track01",
         },
       },
     },
@@ -146,7 +144,6 @@ exports[`parsing pentabarf XML: overview: talks 1`] = `
     "startTime": 1675501200000,
     "subtitle": "",
     "title": "Testcon01: Opening Remarks",
-    "track": "Track01",
   },
 ]
 `;
@@ -182,7 +179,6 @@ exports[`tracks that set a online qa value correctly apply to talks: talks 1`] =
     "startTime": 1675501200000,
     "subtitle": "",
     "title": "Testcon01: Opening Remarks",
-    "track": "TrackWithQA",
   },
   {
     "auditoriumId": "A.01 (Someroom)",
@@ -213,7 +209,6 @@ exports[`tracks that set a online qa value correctly apply to talks: talks 1`] =
     "startTime": 1675502100000,
     "subtitle": "",
     "title": "Testcon01: Opening Remarks",
-    "track": "TrackWithoutQA",
   },
   {
     "auditoriumId": "A.01 (Someroom)",
@@ -244,7 +239,6 @@ exports[`tracks that set a online qa value correctly apply to talks: talks 1`] =
     "startTime": 1675503000000,
     "subtitle": "",
     "title": "Testcon01: Opening Remarks",
-    "track": "UnspecifiedTrack",
   },
   {
     "auditoriumId": "AQ.5 (QA Room)",
@@ -275,7 +269,6 @@ exports[`tracks that set a online qa value correctly apply to talks: talks 1`] =
     "startTime": 1675503900000,
     "subtitle": "",
     "title": "Testcon01: Opening Remarks",
-    "track": "UnspecifiedTrack",
   },
 ]
 `;
diff --git a/src/backends/json/JsonScheduleLoader.ts b/src/backends/json/JsonScheduleLoader.ts
@@ -75,7 +75,6 @@ export class JsonScheduleLoader {
             qa_startTime: null, // TODO
             livestream_endTime: endMoment.valueOf(), // TODO is this right?
             speakers: talk.speakers.map(speaker => this.convertSpeaker(speaker)),
-            track: "", // TODO we have multiple of them!!!
 
             // Must .clone() here because .startOf() mutates the moment(!)
             dateTs: startMoment.clone().startOf("day").valueOf(),

diff --git a/src/backends/penta/PentabarfParser.ts b/src/backends/penta/PentabarfParser.ts
@@ -249,7 +249,6 @@ export class PentabarfParser {
                         slug: pEvent.slug,
                         title: pEvent.title,
                         subtitle: pEvent.subtitle,
-                        track: pEvent.track,
                         speakers: [],
                         prerecorded: true,
                         auditoriumId: auditorium.id,

diff --git a/src/backends/pretalx/PretalxParser.ts b/src/backends/pretalx/PretalxParser.ts
@@ -49,7 +49,6 @@ interface PretalxTalk {
     do_not_record: boolean,
     title: string,
     subtitle: string,
-    track: string,
     type: string,
     language: string,
     abstract: string,
@@ -182,7 +181,6 @@ export async function parseFromJSON(rawJson: string, prefixConfig: IPrefixConfig
                         startTime: eventDate.getTime(),
                         subtitle: event.subtitle,
                         title: event.title,
-                        track: event.track,
                         prerecorded: false,
                         speakers: event.persons.map(p => ({
                             id: p.code,

diff --git a/src/models/schedule.ts b/src/models/schedule.ts
@@ -55,7 +55,6 @@ export interface ITalk {
     slug: string;
     title: string;
     subtitle: string;
-    track: string;
     /**
      * MISNOMER: This variable contains ALL people for the talk, NOT JUST speakers.
      * TODO rename (at a time when it's a less risky change to do...)