Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more thorough tests for device list tracking #459

Merged
merged 5 commits into from
Sep 13, 2022
Merged

Add more thorough tests for device list tracking #459

merged 5 commits into from
Sep 13, 2022

Conversation

squahtx
Copy link
Contributor

@squahtx squahtx commented Sep 9, 2022

Test what happens when local and remote users join and leave rooms.
The previous test only covered local users already in the same room.

Signed-off-by: Sean Quah [email protected]

Add more thorough tests for device list tracking
e7e1c0b 
Test what happens when local and remote users join and leave rooms.
The previous test only covered local users already in the same room.

Signed-off-by: Sean Quah <[email protected]>
@squahtx squahtx requested review from a team as code owners September 9, 2022 13:21
This was referenced Sep 9, 2022
Open
Open
Merged
@squahtx
Copy link
Contributor Author

squahtx commented Sep 9, 2022 •
edited
Loading

TestDeviceListUpdates/when_remote_user_leaves_a_room and TestDeviceListUpdates/when_remote_user_rejoins_a_room will fail until matrix-org/synapse#13749 is merged.

...or I create a matching synapse branch with the fixes.

DMRobertson
DMRobertson reviewed Sep 12, 2022
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, just a a few questions in passing

tests/csapi/device_lists_test.go Show resolved Hide resolved
tests/csapi/device_lists_test.go Outdated Show resolved Hide resolved
tests/csapi/device_lists_test.go Show resolved Hide resolved
tests/csapi/device_lists_test.go Show resolved Hide resolved
tests/csapi/device_lists_test.go Show resolved Hide resolved
tests/csapi/device_lists_test.go Outdated Show resolved Hide resolved
tests/csapi/device_lists_test.go Outdated Show resolved Hide resolved
@squahtx squahtx mentioned this pull request Sep 12, 2022
Open
@squahtx squahtx requested a review from DMRobertson September 12, 2022 18:05
DMRobertson
DMRobertson approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@squahtx squahtx merged commit 4acae02 into main Sep 13, 2022
@squahtx squahtx deleted the squah/test_device_list_tracking branch September 13, 2022 09:26
@DMRobertson DMRobertson mentioned this pull request Sep 13, 2022
Merged
@matrixbot matrixbot mentioned this pull request Dec 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@squahtx @DMRobertson