Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack around a race in the partial-state tests #456

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Hack around a race in the partial-state tests #456

merged 1 commit into from
Aug 26, 2022

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Aug 26, 2022

@richvdh richvdh requested review from a team as code owners August 26, 2022 10:46
squahtx
squahtx approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! it's great to have the flakiness fixed

@richvdh richvdh merged commit 074eb01 into main Aug 26, 2022
@richvdh richvdh deleted the rav/deflake_partialstate_tests branch August 26, 2022 13:02
@richvdh richvdh self-assigned this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squahtx squahtx squahtx approved these changes

Assignees

@richvdh richvdh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complement test TestPartialStateJoin/CanReceiveEventsWithMissingParentsDuringPartialStateJoin is flaky
2 participants
@richvdh @squahtx