Add test to make sure you can find imported events before room creation - MSC3030 #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
MadLittleMods
commented
Jul 6, 2022
| @@ -20,7 +20,7 @@ import ( | |||
| ) | |||
|
|
|||
| func TestJumpToDateEndpoint(t *testing.T) { | |||
| deployment := Deploy(t, b.BlueprintFederationTwoLocalOneRemote) | |||
| deployment := Deploy(t, b.BlueprintHSWithApplicationService) | |||
There was a problem hiding this comment.
Using this blueprint now because we need an application service bridge user to interact as in order to use the ?ts query parameter with the event /send endpoint.
It has the same remote federated homeserver we need here as well.
…able-when-looking-before-room-creation
Co-authored-by: Sean Quah <[email protected]>
MadLittleMods
commented
Jul 7, 2022
squahtx
approved these changes
Jul 7, 2022
MadLittleMods
added a commit
to matrix-org/synapse
that referenced
this pull request
Jul 7, 2022
…before room creation (#13197) Complement tests: matrix-org/complement#405 This happens when you have some messages imported before the room is created. Then use MSC3030 to look backwards before the room creation from a remote federated server. The server won't find anything locally, but will ask over federation which will have the remote event. The previous logic would choke on not having the local event assigned. ``` Failed to fetch /timestamp_to_event from hs2 because of exception(UnboundLocalError) local variable 'local_event' referenced before assignment args=("local variable 'local_event' referenced before assignment",) ```
MadLittleMods
deleted the
madlittlemods/fix-msc3030-unbound-local-variable-when-looking-before-room-creation
branch
|
Thanks for the review @squahtx 🐷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test to make sure you can find imported events before room creation
Synapse changes: matrix-org/synapse#13197
MSC3030