Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markersize validator extended #580

Merged

Conversation

ugorsahin
Copy link
Contributor

The current markersize argument in the plot function only allows the markersize to be an instance of float or integer. Thus, it restricts the usage of size in scatter plots. Extending the validator with pd.Series and np.ndarray help us to utilize the underlying feature. Here is a result using pd.Series for markersize

stock_price

@DanielGoldfarb
Copy link
Collaborator

@ugorsahin
Uğur, Thank you very much for contributing to mplfinance. Can you please post the code that you used to make the example plot above or, if you have time, add the example to the addplot tutorial. Thank you.

@ugorsahin
Copy link
Contributor Author

@DanielGoldfarb

Hello Daniel. I added an example to the addplot tutorial. The cell number is 19. I scaled the values to better show variable marker sizes and added an explanation

variable_scatter

@DanielGoldfarb DanielGoldfarb merged commit dd58ebc into matplotlib:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants