-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added xlabel= kwarg to mpf.plot() #564
Conversation
@vedant-gawande |
issue #427 |
Yeah sure sir, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments. please make minor change requested and push to your fork (will automatically propagate to the PR).
different changes were needed and were made
It turns out that apparently this was not tested at all. A little bit of testing showed that it was not working for all cases where the main plot is not the bottom-most panel.
This changes were made and merged into the PR. @vedant-gawande Thank you for contributing to mplfinance! Wishing you all the best. |
Please merge this repo as you can see i have done the work as per requirement