Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fill_between support for additional plot #511

Closed
wants to merge 4 commits into from
Closed

add fill_between support for additional plot #511

wants to merge 4 commits into from

Conversation

wgong
Copy link
Contributor

@wgong wgong commented Mar 19, 2022

No description provided.

@DanielGoldfarb
Copy link
Collaborator

This looks good. Thanks. Testing this code today.

@wgong
Copy link
Contributor Author

wgong commented Mar 22, 2022

Thank you Mr Goldfarb, I like your pkg mplfinance and have built a small app at https://share.streamlit.io/wgong/streamlitapp/main/demos/demo_etf.py

@DanielGoldfarb
Copy link
Collaborator

@wgong Thank you for sharing your app. I've been playing with it. It's very nice! Great job! I plan to play with it some more next week and read through the code so that I can understand it better. I had not heard of streamlit; it looks like a nice framework for quickly building apps.

Meanwhile, I am enhancing your mplfinance fill_between code to be able to accept a list of dicts, for multiple fill_between (something that people have been requesting for a while). Thank you very much for contributing to mplfinance!

All the best. --Daniel

@DanielGoldfarb DanielGoldfarb mentioned this pull request May 10, 2022
Merged
@DanielGoldfarb
Copy link
Collaborator

This PR was included in PR #529

@DanielGoldfarb DanielGoldfarb added enhancement New feature or request merged / awaiting release to pypi code merged into repo, but not yet released to Pypi released code merged into repo AND released to Pypi and removed merged / awaiting release to pypi code merged into repo, but not yet released to Pypi labels May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request released code merged into repo AND released to Pypi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wgong @DanielGoldfarb