Removed if (plottype not in _valid_types_all) ... and also num_panels = config['num_panels']
#507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unnecessary because the kwarg validator already check whether `kwarg['type']` is in `_valid_types_all`. So if the value passed the validator then it must be in `_valid_types_all`. So we don't need to check again in function `_get_valid_plot_types` (unless...this function is used also by function other than `plotting.plot`)
anbarief
changed the title
if (plottype not in _valid_types_all) ... if (plottype not in _valid_types_all) ... and also num_panels = config['num_panels']
|
How do I update the version here? is it to |
Previously the comments say the max number of panels is 10. So I fixed it to be consistent with the current version, max. panels equal 32.
to show only specific figure created in plotting.py instead of using plt.show we use fig.show. matplotlib#510
src/mplfinance/plotting.py
Outdated
| if config['closefig']: # True or 'auto' | ||
| plt.close(fig) | ||
| elif not config['returnfig']: | ||
| plt.show(block=config['block']) # https://stackoverflow.com/a/13361748/1639359 | ||
| fig.show() # https://stackoverflow.com/a/13361748/1639359 |
There was a problem hiding this comment.
According to the documentation, Figure.show() "does not manage an GUI event loop. Consequently, the figure may only be shown briefly or not shown at all if you or your environment are not managing an event loop. If you're running a pure python shell or executing a non-GUI python script, you should use matplotlib.pyplot.show instead, which takes care of managing the event loop for you."
Therefore I am going to change this back to plt.show(). Otherwise all of the changes look fine and pass unit tests. Will be merging soon.
This was referenced Apr 26, 2022
DanielGoldfarb
added
the
merged / awaiting release to pypi
DanielGoldfarb
added
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unnecessary because the kwarg validator already check whether
kwarg['type']is in_valid_types_all. So if the value passed the validator then it must be in_valid_types_all. So we don't need to check again in function_get_valid_plot_types(unless...this function is used also by function other thanplotinplotting.py)The
num_panels = config['num_panels']was written twice in line 62 and line 66.