Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any reason for the limit of 10 panels? #377

Closed
mattsta opened this issue Apr 15, 2021 · 3 comments
Closed

Any reason for the limit of 10 panels? #377

mattsta opened this issue Apr 15, 2021 · 3 comments
Labels
enhancement New feature or request released code merged into repo AND released to Pypi

Comments

@mattsta
Copy link
Contributor

mattsta commented Apr 15, 2021

I added my 10th panel today and hit two places where the "validators" rejected the plot.

Easy fix: just increase (or remove) the upper limit check. I increased them to 20 in my local source and everything still works.

Any reason the limit is there in the first place?

return panid in ['main','lower'] or (isinstance(panid,int) and panid >= 0 and panid < 10)

'panel_ratios' : { 'Default' : None,
'Validator' : lambda value: isinstance(value,(tuple,list)) and len(value) <= 10 and
all([isinstance(v,(int,float)) for v in value]) },

@DanielGoldfarb
Copy link
Collaborator

DanielGoldfarb commented Apr 15, 2021

No reason. 10 was arbitrary. (I personally can't imagine needing more than 4 or 5). Will up the limit next time I'm in the code. Having some limit helps alert user to typos and similar errors (and also helps manage memory), but i can see upping it to 20 or 30.

@mattsta
Copy link
Contributor Author

mattsta commented Apr 15, 2021

Thanks for the quick confirmation!

(and I do admit my charts are a mess because I just keep appending more signal panels to compare different trade algorithms, but it works for quick visual comparisons—and thanks for making the library so useful!)

Screen Shot 2021-04-15 at 16 32 44

Screen Shot 2021-04-15 at 16 34 02

@DanielGoldfarb
Copy link
Collaborator

@mattsta
Matt,
Thanks for sharing you charts. I really enjoy seeing the creative things that people are doing with mpfinance.
All the best. --Daniel

@DanielGoldfarb DanielGoldfarb added enhancement New feature or request in progress labels Apr 16, 2021
@DanielGoldfarb DanielGoldfarb added released code merged into repo AND released to Pypi and removed in progress labels Apr 25, 2021
DanielGoldfarb added a commit that referenced this issue Oct 2, 2022
Change maximum panels to 32 in docs & examples, in regards to completion of #377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released code merged into repo AND released to Pypi
Projects
None yet
Development

No branches or pull requests

2 participants