Style fixes for secondary_axis. #14591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afvincent
reviewed
Jun 20, 2019
| @@ -254,9 +235,7 @@ def draw(self, renderer=None, inframe=False): | |||
| using the converter specified by | |||
| `~.axes._secondary_axes.set_functions` (or *functions* | |||
| parameter when axes initialized.) | |||
|
|
|||
| """ | |||
There was a problem hiding this comment.
By curiosity, is there a reason for removing the blank line after the docstring? It looks like the file already hosts a mix of “blank line”/“no blank line” after a docstring anyway…
There was a problem hiding this comment.
See PyCQA/pydocstyle#361 for how I tend to use blank lines (basically, use one if the body has other blank lines). Not really strict about that, but given that you asked, I made the changes throughout the module :)
There's a lot of unused imports :)
anntzer
force-pushed
the
secondaryimports
branch
from
53b7239
to
ec6fe36
Compare
afvincent
approved these changes
Jun 20, 2019
jklymak
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot of unused imports :)
PR Summary
PR Checklist