numpy 2.0 compatibility np.unicode_ #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MatthewFlamm Thank you!! |
|
This change is now available in the newest version of cmocean on PyPI (v3.1.3) and should shortly be available on conda-forge too. Thanks again. |
Closed
|
Thanks for quickly releasing! |
|
Can I just state again how great this was for you to do? I just hit this myself in my own older version of cmocean and realized you had already fixed it as I was going in to do it myself and couldn't get another version of my code to hit the error because I already had your fix in it. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also assume that the check for python 2.0 is no longer needed since setup.py requires python >= 3.8.
See https://numpy.org/devdocs/numpy_2_0_migration_guide.html#main-namespace
Closes #98