Managing WebMapService constructor parameters when available #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
managing WebMapService constructor parameters when available
Kurea
changed the title
|
@molinav can you help me on that? I'm not sure the issue is due to something I did. |
|
Hi, @Kurea! I think everything is fine on your side. I took a fast look at your code last week and looked good to me. I just wanted to check a bit more thoroughly before merging, but I have been a bit busy at work in the last days. I will come back soon to it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
managing WebMapService constructor parameters when available
See related issue here : #602