Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow packaging version 24.0 #601

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

frenzymadness
Copy link
Contributor

I'm gonna test it in Fedora Linux.

@molinav
Copy link
Member

molinav commented Mar 11, 2024

Hi @frenzymadness! Thanks, I guess it will be no problem to update the upper pin. I usually add upper pins in all the dependencies because I had problems in the past with new releases of dependencies that were breaking the library. The downside is that these upper pins need to be updated regularly.

Let's wait until the workflows pass and I will merge it.

@molinav molinav merged commit 461b402 into matplotlib:develop Mar 11, 2024
@frenzymadness
Copy link
Contributor Author

Thank you. I understand the reasons for the upper pins and they make sense for virtual environments. But when we update a package in Linux distribution, we have to adjust or remove them because we can have only one version of each package available (usually).

@molinav
Copy link
Member

molinav commented Mar 12, 2024

For the future I will need to search if I can add some bot that reminds me to update upper pins whenever a new release appears in PyPI. Otherwise, in times that I am too busy I might get delayed unless people like you take the effort to create a PR.

Do you need a specific tag release in PyPI with this change or are you cloning directly from the develop branch?

@frenzymadness frenzymadness deleted the packaging branch March 12, 2024 10:20
@frenzymadness
Copy link
Contributor Author

If you have nothing else to release, don't do one just for this change. We can take it as a patch from this PR and remove it in the future when it gets invalid after the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants