Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating notification types to prevent them from displaying too long #970

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

snake14
Copy link
Contributor

@snake14 snake14 commented Jan 9, 2025

Description:

Updating notification types to prevent them from displaying too long.

NOTE: We aren't changing the lifespan of notifications which contain a CTA, like a link.

Fixes: #891

Review

Copy link
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left 1 comment, based on that will approve the PR.
I can confirm that when a user without publish capability edits tag/trigger/variable, the notification type is toast else transient.

Also the notification is now changed to toast for container, import version and version add/edit.

@snake14 snake14 merged commit 002ddae into 5.x-dev Jan 10, 2025
5 checks passed
@snake14 snake14 deleted the PG-3897-change-notification-type branch January 10, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Alert does not disappear
2 participants