Skip to content

Commit

Permalink
Merge pull request #951 from matomo-org/PG-3914-fix-variable-description
Browse files Browse the repository at this point in the history
Fix etracker tag and variable descriptions
snake14 authored Dec 13, 2024

Verified

This commit was signed with the committer’s verified signature.
reneme René Meusel
2 parents 2f88edb + e407d45 commit cf90dde
Showing 11 changed files with 21 additions and 21 deletions.
6 changes: 0 additions & 6 deletions Template/Tag/EtrackerTag.php
Original file line number Diff line number Diff line change
@@ -19,12 +19,6 @@ class EtrackerTag extends BaseTag
{
public const PARAM_ETRACKER_CONFIG = 'etrackerConfig';

public function getDescription()
{
return Piwik::translate('TagManager_EtrackerTagDescriptionNew');
}


public function getIcon()
{
return 'plugins/TagManager/images/icons/etracker.svg';
5 changes: 5 additions & 0 deletions Template/Variable/EtrackerConfigurationVariable.php
Original file line number Diff line number Diff line change
@@ -22,6 +22,11 @@ public function getId()
return self::ID;
}

public function getDescription()
{
return Piwik::translate('TagManager_EtrackerMainVariableDescription');
}

public function getCategory()
{
return self::CATEGORY_OTHERS;
3 changes: 2 additions & 1 deletion lang/en.json
Original file line number Diff line number Diff line change
@@ -391,7 +391,8 @@
"ErrorXNotWhitelisted": "The value for \"%1$s\" is not allowed, use one of: %2$s.",
"ErrorXTooLong": "\"%1$s\" is too long, max %2$s characters are allowed.",
"EtrackerTagName": "etracker web analysis",
"EtrackerTagDescriptionNew": "Defines the configuration for eTracker Analytics to optimise data collection.",
"EtrackerTagDescription": "etracker is a web analytics system, you can choose to send a pageview or an event.",
"EtrackerMainVariableDescription": "Defines the configuration for eTracker Analytics to optimise data collection.",
"EtrackerTagHelp": "The etracker tag tracks and sends data on user interactions for pageviews or specific events.",
"EventActionHelp": "The event's action, for example Play, Pause, Duration, Add Playlist, Downloaded, Clicked…",
"EventCategoryHelp": "The event's category, for example Videos, Music, Games…",
Original file line number Diff line number Diff line change
@@ -894,7 +894,7 @@
<row>
<id>Etracker</id>
<name>etracker web analysis</name>
<description>Defines the configuration for eTracker Analytics to optimise data collection.</description>
<description>etracker is a web analytics system, you can choose to send a pageview or an event.</description>
<category>Analytics</category>
<icon>plugins/TagManager/images/icons/etracker.svg</icon>
<help>The etracker tag tracks and sends data on user interactions for pageviews or specific events.</help>
Original file line number Diff line number Diff line change
@@ -599,7 +599,7 @@
<row>
<id>EtrackerConfiguration</id>
<name>EtrackerConfiguration</name>
<description />
<description>Defines the configuration for eTracker Analytics to optimise data collection.</description>
<category>Others</category>
<icon>plugins/TagManager/images/icons/etracker.svg</icon>
<help />
4 changes: 2 additions & 2 deletions tests/UI/expected-screenshots/ContainerTag_create_new.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit cf90dde

Please sign in to comment.