Remove suhosin test

[ziegenberg]

Description:

Suhosin is a PHP security extension aimed at PHP version 5.x and Matomo 4 requires at least PHP version 7.2.5, so this can safely go.

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[snake14]

Seems reasonable to me. Any concerns @sgiehl ?

[sgiehl]

While Suhosin might not be relevant for PHP 7 & 8 anymore, it might be worth looking at Suhosin NG or Snuffleupagus (https://github.com/jvoisin/snuffleupagus) as replacement. Not sure if it would be worth to detect those instead.

[Findus23]

Just as a reminder, most tests of this plugin are severely outdated and might not actually give useful tips:
#27

[ziegenberg]

How prevalent is Snuffleupagus among the current Matomo installations out there?

[ziegenberg]

I rebased onto the current 5.x-dev branch and switched the base branch of this PR. What is needed to finalise this?

[snake14]

I rebased onto the current 5.x-dev branch and switched the base branch of this PR. What is needed to finalise this?

That works for me. @sgiehl I created a new issue to look into adding a test for snuffleupagus. Any objections to merging this PR?

[sgiehl]

No. Guess merging that should be fine.