Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some searchengines #81

Closed
wants to merge 3 commits into from
+10 −14
Closed

Adding some searchengines #81

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd5859b
Adding some pages to SearchEngines
Jul 1, 2013
67b0efd
fix typo
Jul 1, 2013
dfd6ed4
Remove Piwik mobile add from top menu
Jul 15, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions core/DataFiles/SearchEngines.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@
'{}.search-results.com' => array('Ask'),
'{}.search.ask.com' => array('Ask'),
'avira-int.ask.com' => array('Ask'),
'avira.search.ask.com' => array('Ask'),

// Atlas
'searchatlas.centrum.cz' => array('Atlas', 'q', '?q={k}'),
Expand Down Expand Up @@ -290,6 +291,9 @@

// DuckDuckGo
'duckduckgo.com' => array('DuckDuckGo', 'q', '?q={k}'),

// Ebay
'ebay.de' => array('Ebay', '_nkw'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ebay is not really a search eninge. Or is there a way to go to an external page by searching?


// earthlink
'search.earthlink.net' => array('Earthlink', 'q', 'search?q={k}'),
Expand Down Expand Up @@ -375,6 +379,9 @@
// Gigablast
'www.gigablast.com' => array('Gigablast', 'q', 'search?q={k}'),
'dir.gigablast.com' => array('Gigablast (Directory)', 'q'),

// GMX
'suche.gmx.net' => array('GMX', 'su'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one already exists as google powered search engine. If the keyword param 'su' is valid aswell, please add it there


// Gnadenmeer
'www.gnadenmeer.de' => array('Gnadenmeer', 'keyword'),
Expand Down Expand Up @@ -702,6 +709,9 @@

// Poisk.Ru
'poisk.ru' => array('Poisk.Ru', 'text', 'cgi-bin/poisk?text={k}', 'windows-1251'),

// Preisvergleich.de
'preisvergleich.de' => array('Preisvergleich.de', 'query'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't add that aswell. A shop listed on such a page should use campaigns to track the traffic. I don't think there would any shop be automatically crawled and listed without having an affiliate programm or something like that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ebay.de, Preisvergleich.de and others belong to Adword SearchNetwork, so you could be listed via keywords you pay for (not as a product itself but as advertisment on that pages). So if you use urls like www.domain.xy/?pk_campaign=Adwords (without pk_kwd) in your Adwords campaigns, Piwik will check the referer to determine the real searched keyword, and adding this pages to searchengines datafile would allow piwik to guess the keyword for this pages, too. Add the moment piwik shows only the url "www.ebay.de" but that's not really useful. And if you use pk_kwd in Adwords Campaign you only get the keyword you added, not the real searched one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevertheless ebay.de and preisvergleiche.de are imho not what piwik should recognize as a search engine

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, shops shouldnt be listed as search engine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, what about adding a new Datafile which will only be parsed if pk_campaign without keyword is detected?


// qip
'search.qip.ru' => array('qip.ru', 'query', 'search?query={k}'),
Expand Down