Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 Script error in segmentation #76

Merged
merged 1 commit into from
Jun 2, 2013
Merged

IE8 Script error in segmentation #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions plugins/SegmentEditor/templates/Segmentation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,9 @@ Segmentation = (function($) {

var getSegmentFromId = function (id) {
if(self.availableSegments.length > 0) {
for(var key in self.availableSegments)
for(var i = 0; i < self.availableSegments.length; i++)
{
segment = self.availableSegments[key];
segment = self.availableSegments[i];
if(segment.idsegment == id) {
return segment;
}
Expand All @@ -206,9 +206,9 @@ Segmentation = (function($) {
+ ' ' + self.translations['General_DefaultAppended']
+ '</span></li> ';
if(self.availableSegments.length > 0) {
for(var key in self.availableSegments)
for(var i = 0; i < self.availableSegments.length; i++)
{
segment = self.availableSegments[key];
segment = self.availableSegments[i];
injClass = "";
if( segment.definition == self.currentSegmentStr){
injClass = 'class="segmentSelected"';
Expand Down Expand Up @@ -247,9 +247,9 @@ Segmentation = (function($) {
+ '">' + self.translations['SegmentEditor_AddNewSegment']
+ '</option>';
segmentsDropdown.append(newOption);
for(var key in self.availableSegments)
for(var i = 0; i < self.availableSegments.length; i++)
{
segment = self.availableSegments[key];
segment = self.availableSegments[i];
newOption = '<option data-idsegment="'+segment.idsegment+'" data-definition="'+(segment.definition).replace(/"/g, '&quot;')+'" title="'+segment.name+'">'+self.shortenSegmentName(segment.name)+'</option>';
segmentsDropdown.append(newOption);
}
Expand Down