Fix User ID Segmentation #6954
Merged
Fix User ID Segmentation #6954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jantlwoomy would you mind first creating an issue for the bug, with steps to reproduce, and expected results VS got result? and please link #6954 from your issue. I'm not sure that this change is valid, but let's see! cheers |
mattab
added
the
answered
|
Thanks @jantlwoomy for the PR! Fixes #6959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to segment all visits to Users and Not users.
Segmentation with rules User Id, Not equal, Empty generates next SQL:
( log_visit.idvisitor IS NOT NULL AND (log_visit.idvisitor <> '' OR log_visit.idvisitor = 0)But in case Anonymous visitor there is Visitor ID but no User ID.
So after fix SQL changing for this:
( log_visit.user_id IS NOT NULL AND (log_visit.user_id <> '' OR log_visit.user_id = 0) )