Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

matomo-org / matomo Public

Notifications You must be signed in to change notification settings
Fork 2.7k
Star 20.1k

Code
Issues 2.4k
Pull requests 69
Actions
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Wiki
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various problems related to GDPR tools #22975

Merged

nathangavin merged 1 commit into dev-16739 from dev-16739-userid-fix

Jan 24, 2025

Merged

Fix various problems related to GDPR tools #22975

nathangavin merged 1 commit into dev-16739 from dev-16739-userid-fix

Jan 24, 2025

Conversation 9 Commits 1 Checks 26 Files changed

Conversation

Copy link

Member

sgiehl commented Jan 23, 2025

Description:

This PR fixes a couple of problems and adds improvements around the GDPR tools.

I'll add some inline comments to explain every fix in detail

Review

Functional review done
Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
Security review done
Wording review done
Code review done
Tests were added if useful/possible
Reviewed for breaking changes
Developer changelog updated if needed
Documentation added if needed
Existing documentation updated if needed

Sorry, something went wrong.

All reactions

sgiehl requested a review from nathangavin

January 23, 2025 19:18

sgiehl commented

View reviewed changes

plugins/API/API.php Show resolved Hide resolved

sgiehl commented

View reviewed changes

plugins/CoreHome/Columns/UserId.php Show resolved Hide resolved

sgiehl commented

View reviewed changes

plugins/Live/Live.php Show resolved Hide resolved

sgiehl commented

View reviewed changes

plugins/PrivacyManager/vue/src/ManageGdpr/ManageGdpr.vue Show resolved Hide resolved

sgiehl commented

View reviewed changes

plugins/PrivacyManager/vue/src/ManageGdpr/ManageGdpr.vue Show resolved Hide resolved

sgiehl commented

View reviewed changes

plugins/SegmentEditor/vue/src/SegmentGenerator/SegmentGenerator.vue Show resolved Hide resolved


          Fix various problems related to GDPR tools

685fad6

sgiehl force-pushed the dev-16739-userid-fix branch from e2a0568 to 685fad6 Compare

January 23, 2025 19:47

sgiehl commented

View reviewed changes

plugins/Live/javascripts/visitorProfile.js Show resolved Hide resolved

sgiehl commented

View reviewed changes

plugins/PrivacyManager/vue/src/ManageGdpr/ManageGdpr.vue Show resolved Hide resolved

nathangavin approved these changes

View reviewed changes

Copy link

Contributor

nathangavin left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sorry, something went wrong.

All reactions

nathangavin merged commit 13b46eb into dev-16739

21 of 26 checks passed

nathangavin deleted the dev-16739-userid-fix branch

January 24, 2025 03:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nathangavin nathangavin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.