Dev 18809 make set user access atomical

[caddoo]

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[sgiehl]

I guess at this point we would need to remove all capabilities that were set for a specific site, as deleteUserAccess is no longer called upfront. If there are new capabilities that should be set, that will happen below.

Another possibility is to iterate over each site, check which capabilities are already set and which should be set. And based on a diff remove or add capabilities.

[caddoo]

@sgiehl can you elaborate why need to remove all capabilities here, why would new capabilities have to be set if the exception is thrown?

The flows are either:

• Update role fails - capabilities don't get touched.
• Update role is successful - capabilities get updated.