Improve error visuals for All Websites Dashboard #22872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathangavin
added
Needs Review
plugins/MultiSites/vue/src/AllWebsitesDashboard/AllWebsitesDashboard.vue
Outdated
Show resolved
Hide resolved
valentinab25
pushed a commit
to valentinab25/matomo
that referenced
this pull request
Jan 27, 2025
* Add new message for All Websites error message * Move Error message on All Websites and suppress error notification * Build vue files * Fixed UI test failure caused by updating All Websites Dashboard error location * Reset files changed by vue compilation * remove unnecessary placeholder values * resolve merge conflict issues and odd file generation * Add removed UI test image * Build vue files * Update UI test due to moving error location on page * reset files modified by vue compilation --------- Co-authored-by: innocraft-automation <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Improves the Error visuals on the All Websites Dashboard. Moves the error message location and changes the text to be more descriptive.
Review