Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include date in CLI logging #21940

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Include date in CLI logging #21940

merged 1 commit into from
Feb 14, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 14, 2024 •
edited
Loading

Description:

Log output on CLI seems to have changed slightly with Matomo 5:

before Matomo 5: INFO [2024-02-01 22:27:07] 8632 INIT
Matomo 5: INFO [08:03:33] 11096 INIT

As the date is quite useful, this PR readds it to the logging on CLI.

fixes #21924

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Feb 14, 2024
@sgiehl sgiehl added this to the 5.0.3 milestone Feb 14, 2024
@sgiehl sgiehl requested a review from a team February 14, 2024 10:13
mneudert
mneudert approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@mneudert mneudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like symfony/monolog-bridge:3.3.0 added the new default format.

@mneudert mneudert linked an issue Feb 14, 2024 that may be closed by this pull request
[Bug] cron:archive CLI changed response format in Matomo 5 - instead of DateTime before every row, only time is displayed #21924
Closed
4 tasks
@mneudert mneudert merged commit 260ae34 into 5.0.x-dev Feb 14, 2024
22 of 25 checks passed
@mneudert mneudert deleted the m21924 branch February 14, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mneudert mneudert mneudert approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.3
2 participants
@sgiehl @mneudert