Improve escaping of values in CSV exports #21719
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Our CSV files are using a normal comma as separator. Currently values will be only surrounded by double quotes if they contain such a comma or a double quote. This works perfectly fine when opening such a file and choosing the correct separator.
Some tools allow to use multiple separators. Typically those separator are either comma, semicolon or tab.
Using all of them at once, would currently only break if a string contains a semicolon, as tabs are removed from values anyway and commas are correctly escaped.
For a better compatibility this PR adds the automatic escaping for all typical separators.
refs AS-288
Review