Fix problem with unprefixed group by columns in select queries

[sgiehl]

Description:

When complex queries are built it can happen that some columns exists in more than one table.
The method to build the query had a bug, where the column names used in the order by were not prefixed in all cases.

I was able to reproduce the problem when setting [General] enable_segments_cache = 0 in the config.
And triggering the archiving for e.g. DevicesDetection while using a segment like browserCode==FF.

The archiving for DevicesDetection will trigger an aggregation for conversion and so creates a query that joins log_visit and log_conversion. Both tables share a couple of dimensions. When it e.g. queries for config_browser_name, this fails if the column is not prefixed in order by.

Note: While moving around the code I was wondering about the special handling of referrer_data. Seems there actually is no reason for that special handling, as the way the query is built in transitions plugin could be easily changed to avoid any special handling at all.

fixes #21351

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed