Fix Deprecation Warning for trim() Function in awkExistsAndRunsCorrectly()

[mindbreaker]

Description:

This pull request addresses a deprecation warning that arises when a null value is passed to the trim() function in the awkExistsAndRunsCorrectly() method.

Changes:

• Added a ternary check to ensure that the trim() function is only called if the output from the shell command is not null.
  

• If the output is null, the function will now return false.
  

This change prevents the deprecation warning and ensures compatibility with the updated behavior of the trim() function in PHP.

fixes #20959

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[michalkleiner]

Thanks for the PR, @mindbreaker. The usual approach is to use the null-coalesce operator ?? that ensures a fallback value is provided when the tested value is null. Could you update the code as suggested? I'd be happy to merge it then.

[sgiehl]

Thanks @mindbreaker for your contribution 🎉

[FabianSchmick]

Can this fix also please be merged into the current maintained Version 4.x ?

[sgiehl]

@FabianSchmick I've just cherry-picked that to 4.x, so it will be included in the next release there as well.

[FabianSchmick]

Great! Thank you