in AutoSuggestAPITest make sure static var overrides are undone after the test finishes #20828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently this is done outside the test class, in the global scope, which means it will be run if the file is included and not undone. This is a problem if you write your own tests for the autosuggest API in a plugin, and expect the value to be it's default (because phpunit will include the file when running the plugin test suite).
This cost me about ~6 hrs of debugging time to find so I thought I'd prevent it from happening again.
Review