Ensure series label isn't set to null #20806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
sgiehl
commented
May 30, 2023
Comment on lines
+241
to
+243
| if (isset($this->ordinateLabels[$column])) { | ||
| $this->pData->setSerieDescription($column, $this->ordinateLabels[$column]); | ||
| } |
There was a problem hiding this comment.
I wasn't able to recreate that locally, but this seems to be the only place within Matomo where the series description might get set to null. Not sure in which exact case $this->ordinateLabels[$column] might not be set, but maybe there are some edge cases. Even though this should actually trigger another warning for accessing a not existent array key...
michalkleiner
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fixes #20655
Review