Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve brute force protection checks #20543

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 31, 2023

Description:

Simplifies the check and ensure we always check for blocked IPs and logins

Review

@sgiehl sgiehl added c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review labels Mar 31, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Mar 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Apr 8, 2023
@sgiehl sgiehl requested review from tsteur and bx80 April 12, 2023 15:01
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and makes the code easier to follow 👍

@sgiehl sgiehl merged commit c740439 into 5.x-dev Apr 13, 2023
@sgiehl sgiehl deleted the improvebruteforcechecks branch April 13, 2023 13:12
sgiehl added a commit that referenced this pull request Apr 13, 2023
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Stale The label used by the Close Stale Issues action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants