Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some more PHP 8.2 deprecations #20235

Merged
merged 2 commits into from
Jan 21, 2023
Merged

Fix some more PHP 8.2 deprecations #20235

merged 2 commits into from
Jan 21, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 18, 2023

Description:

Added some missing class attributes to avoid deprecation notices, applied some code formatting and simplifications.

refs #19343

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jan 18, 2023
@sgiehl sgiehl added this to the 4.13.2 milestone Jan 18, 2023
@sgiehl sgiehl requested a review from bx80 January 18, 2023 14:22
@sgiehl sgiehl mentioned this pull request Jan 18, 2023
6 tasks
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bx80 bx80 merged commit 60b23ef into 4.x-dev Jan 21, 2023
@bx80 bx80 deleted the php82fixes branch January 21, 2023 02:14
@MatomoForumNotifications

This pull request has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/deprecated-warning-after-update-from-4-12-3-to-4-13-1-should-be-reported-here/49324/2

@bx80 bx80 added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants