PHP 7.4 warning in ColumnDelete #15224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Findus23
reviewed
Dec 2, 2019
|
|
||
| if (!array_key_exists($column, $row)) { | ||
| continue; | ||
| if (is_array($row )) { |
There was a problem hiding this comment.
Seems like there is a space too much here:
Suggested change
| if (is_array($row )) { | |
| if (is_array($row)) { |
tsteur
commented
Dec 2, 2019
|
|
||
| if (!array_key_exists($column, $row)) { | ||
| continue; | ||
| if (is_object($row)) { |
There was a problem hiding this comment.
@sgiehl I reckon it's not working maybe because we need to use indeed isset() or so as in the row object it might not have the property...
wondering if we even need this code at all as maybe unset would do the work anyway no matter if the property/key is set?
There was a problem hiding this comment.
We couldn't remove it actually.
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
* PHP 7.4 warning in ColumnDelete fix matomo-org#15210 * remove tabs * Update ColumnDelete.php * Update ColumnDelete.php * Update ColumnDelete.php * Update ColumnDelete.php * Update ColumnDelete.php
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
* PHP 7.4 warning in ColumnDelete fix matomo-org#15210 * remove tabs * Update ColumnDelete.php * Update ColumnDelete.php * Update ColumnDelete.php * Update ColumnDelete.php * Update ColumnDelete.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15210