Add possibility for themes to change text color in header #12204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
Needs Review
|
UI test failures are not from this PR |
sgiehl
requested changes
Oct 18, 2017
CHANGELOG.md
Outdated
| ## Piwik 3.2.1 | ||
|
|
||
| ### New APIs | ||
| * Themes can now customer the header text color using `@theme-color-header-text` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12201 If I understand it correctly, the color in the header should be changeable which I totally agree to in order to make it useful.
Expecting UI tests to fail for the theming part with black menu text color.
For the variable I used the ending
-texteven though they are technically links (-link) to be consistent with the menu.