Allow to provide secondary sort column for reports #12128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
force-pushed
the
secondarysort
branch
from
30ee6ea to
fbb2e65
Compare
mattab
reviewed
Oct 5, 2017
core/Plugin/Report.php
Outdated
| * ``` | ||
| * @return null|callable | ||
| */ | ||
| public function getSecondSortColumnCallback() |
There was a problem hiding this comment.
would rename to getSecondarySortColumnCallback
|
this looks good to me 👍 We could later also make this available as a global API parameter filter. |
mattab
added
c: Platform
mattab
added
the
Pull Request WIP
|
Feedback
|
sgiehl
changed the title
|
Added some unit tests |
sgiehl
added
Needs Review
sgiehl
force-pushed
the
secondarysort
branch
2 times, most recently
from
b889769 to
22a654c
Compare
sgiehl
force-pushed
the
secondarysort
branch
2 times, most recently
from
ca199fd to
3db458c
Compare
diosmosis
reviewed
Jun 13, 2018
core/DataTable/Filter/Sort.php
Outdated
| @@ -90,7 +93,11 @@ public function filter($table) | |||
| $config->primaryColumnToSort = $sorter->getPrimaryColumnToSort($table, $this->columnToSort); | |||
| $config->primarySortOrder = $sorter->getPrimarySortOrder($this->order); | |||
| $config->primarySortFlags = $sorter->getBestSortFlags($table, $config->primaryColumnToSort); | |||
| $config->secondaryColumnToSort = $sorter->getSecondaryColumnToSort($row, $config->primaryColumnToSort); | |||
| if (!empty($this->secondaryColumnSortCallback)) { | |||
| $config->secondaryColumnToSort = call_user_func($this->secondaryColumnSortCallback, $config->primaryColumnToSort); | |||
There was a problem hiding this comment.
Would it make sense to provide the table as well to the callback function? I'm wondering if it could be useful in some case to make the sort column change based on the contents of the report...
There was a problem hiding this comment.
added $table as additional param. might be useful in some cases...
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Allow to provide secondy sort column for reports * rename method * Adds two simple tests to prove secondary column sorting * invoke sort callback with datatable as second parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to make it possible to sort reports by a custom secondary column as described in #12127
This is only a prove of concept atm.
If we decide to use it that way I'd go on with adding some tests for it...