Add tests for piwik/searchengine-and-social-list#14

[piwikjapan]

Add tests for matomo-org/searchengine-and-social-list#14
Use kanji strings instead of just 'Piwik'.

[piwikjapan]

Maybe, mb_detect_encoding which indicated multiple Japanese encodes did not work on this travis-ci environment.

[mattab]

Hi @piwikjapan
Thanks for the pull request!

the build is failing on Travis CI - do the tests work for you locally?

[mattab]

@piwikjapan since the changes in matomo-org/searchengine-and-social-list#14 were merged only few days ago, to have those changes included in your pull request, you must use the version 1.3.1 of this library (try running composer update piwik/piwik/searchengine-and-social-list)

[piwikjapan]

I updated to the version 1.3.1, and ./console tests:run ./plugins/Referrers/tests/Unit/SearchEngineTest.php shown below:

1. Piwik\Plugins\Referrers\tests\SearchEngineTest::testMissingSearchEngineIcons with data set adding support for windows phone 7 version 7.5 #1 ('www.118700.se', array(array('q'), 'sok.aspx?q={k}', '118 700'))
   www.118700.se
   Failed asserting that false is true.

/home/yamachan/piwik/plugins/Referrers/tests/Unit/SearchEngineTest.php:144

2. Piwik\Plugins\Referrers\tests\SearchEngineTest::testMissingSearchEngineIcons with data set Minor adminmenu improvements #22 ('www.allaverksamheter.se', array(array('What'), 'SearchResult.aspx?What={k}', 'Allaverksamheter'))
   www.allaverksamheter.se
   Failed asserting that false is true.

/home/yamachan/piwik/plugins/Referrers/tests/Unit/SearchEngineTest.php:144

3. Piwik\Plugins\Referrers\tests\SearchEngineTest::testMissingSearchEngineIcons with data set Parse replay-to header in the same way like from #332 ('www.isodelen.se', array(array('Keywords'), 'sokresultat?Keywords={k}', 'Isodelen'))
   www.isodelen.se
   Failed asserting that false is true.

/home/yamachan/piwik/plugins/Referrers/tests/Unit/SearchEngineTest.php:144

4. Piwik\Plugins\Referrers\tests\SearchEngineTest::testMissingSearchEngineIcons with data set explode(): Empty delimiter in archive.sh daily run #424 ('www.riksdelen.se', array(array('What'), 'SearchResult.aspx?What={k}', 'Riksdelen'))
   www.riksdelen.se
   Failed asserting that false is true.

but there are not essential and all my tests (that's I am asking to merge) were successful.

[sgiehl]

we need to add some icons for those new search engines. Btw. could you please undo the changes to the access mode of core/Tracker/PageUrl.php. You've changed it from 100644 → 100755

[piwikjapan]

I watched https://travis-ci.org/piwik/piwik/jobs/151990012 carefully,

Piwik\Plugins\Referrers\tests\SearchEngineTest::testExtractInformationFromUrl with data set #75
(Successfully with utf-8. Therefore, it does not show anything.)

l. 1158
3) Piwik\Plugins\Referrers\tests\SearchEngineTest::testExtractInformationFromUrl with data set #76
Unsuccessfully with Shift_JIS.

Array (
'name' => 'Yahoo! Japan Images'

• 'keywords' => '君の名は。'
• 'keywords' => '?n?̖??́b'
  )

l. 1171
4) Piwik\Plugins\Referrers\tests\SearchEngineTest::testExtractInformationFromUrl with data set #77
Unsuccessfully with EUC-JP.
Array (
'name' => 'Yahoo! Japan Images'

• 'keywords' => '君の名は。'
• 'keywords' => '????̾?ϡ?'
  )

On Travis CI,
I thought that all tests except UTF-8 fell. But another tests except UTF-8 (e.g. with EUC-KR) has been successfully.
Therefore, the problem shown when some charsets in SearchEngines.yml, the first charset will be successful, but the second and third will fail.

It means,

actual condition:

Yahoo! Japan Images:

urls:
  - image.search.yahoo.co.jp
params:
  - p
backlink: 'search?p={k}'
charsets:
  - utf-8     -> success
  - euc-jp    -> fail
  - ms932     -> fail

my imagination:

charsets:
  - ms932     -> will be successful
  - utf-8     -> will fail
  - euc-jp    -> will fail

or:

charsets:
  - euc-jp    -> will be successful
  - ms932     -> will fail
  - utf-8     -> will fail

[sgiehl]

Travis won't use the new version of piwik/searchengine-and-social-list unless the composer.lock is changed here.

[mattab]

@piwikjapan try running composer update piwik/piwik/searchengine-and-social-list in your branch and push the updated composer.lock to the pull request, this may fix your issue?