Adds proxy method to call API using session #10201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
the
Pull Request WIP
sgiehl
added
not-in-changelog
| @@ -111,7 +111,7 @@ public function showInContext() | |||
| $controllerName = Common::getRequestVar('moduleToLoad'); | |||
| $actionName = Common::getRequestVar('actionToLoad', 'index'); | |||
|
|
|||
| if($controllerName == 'API') { | |||
| if($controllerName == 'API' || ($controllerName == 'Proxy' && $actionName == 'callApi')) { | |||
There was a problem hiding this comment.
Could you move whole this condition to separate method eg. isSupportedRequest or isAllowedRequest ?
|
@sgiehl 👍 (I left a few comments) |
|
Thx for the comments. I'll check those the comming days |
…ntication; use proxy method for scheduled reports download links
…o avoid exposing of token_auth
|
@andrzejewsky I've adjusted most of the stuff according to your feedback. @tsteur @mattab anyone time for a quick look at the PR, so we can merge it? |
|
I'm quite busy :( don't think I'll have time for it soon as it will take some time re security etc |
|
Maybe some tests could be added? Or is tested via the export UI tests already maybe? |
|
Review
|
|
fyi reasons for not merging were:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New proxy method is used for download links in email reports and datatables, to avoid exposing the token_auth in direct API urls.
fixes #10185
fixes #10147