-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary require_once from codebase #803
Comments
|
|
(In [1225]) refs #803 - add autoloader to tests |
|
My thought is to leave subclassed Exceptions where they are. We can add code to the autoloader to handle this, assuming I got the renaming right. Something like Auth_Result should be in its own file for speed and consistency. An alternative is to continue to use require_once for these cases. |
Actually, Piwik_Auth_Result isn't a good example as it and Piwik_Auth are currently always used in the same context. (core/Access.php, core/Auth.php, plugins/Login/Auth.php) |
(In [1228]) refs #803 - auto-discovery algorithm to handle class Piwik, files with |
(In [1229]) refs #803 - temp fix: PluginsManager defines functions in global scope |
(In [1231]) refs #803 - temp fix; Translate.php contains global scope functions |
(In [1232]) refs #803 - Log/Exception contains classes that won't be found by |
(In [1233]) refs #803 - Auth is loaded by piwik.php? |
Ok, files containing global scope functions will continue to be manually included (via require_once). |
(In [1248]) refs #803 comment:11 - rename Log Formatter classes for consistency |
increasing priority - now that the loader is in place, maybe we should aim to close the ticket and remove all require_once - vipsoft if you disagree please reset the milestone |
(In [1296]) fixes #803 - remove unnecessary require_once from core, plugins, and parts of |
In #620, we implemented an autoloader. In this ticket, we clean up the code by removing unnecessary require_once statements. This will require some analysis.
Don't change:
The text was updated successfully, but these errors were encountered: