Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading Goal reports calls the API with segmentation which can be slow and should be pre-processed #2981

Closed
mattab opened this issue Feb 27, 2012 · 6 comments
Closed

Loading Goal reports calls the API with segmentation which can be slow and should be pre-processed #2981

mattab opened this issue Feb 27, 2012 · 6 comments
Assignees
@mattab
Labels
c: Performance For when we could improve the performance / speed of Matomo. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
2.2.1

Comments

@mattab
Copy link
Member

mattab commented Feb 27, 2012

Currently, loading a Goal report causes an API call with &segment=visitorType==returning,visitorType==returningCustomer

See code:
https://github.com/piwik/piwik/blob/master/plugins/VisitFrequency/API.php#L25

This is fine, but we should ensure that this specific API call with this specific segment is pre-processed as part of the archive.php call.
@mattab
Copy link
Member Author

mattab commented May 29, 2012

See #3144 as a requirement to fix

@mattab
Copy link
Member Author

mattab commented Jun 3, 2012

Very important to fix as this is the only piece of data not pre-archived in Piwik.

@mattab
Copy link
Member Author

mattab commented Mar 15, 2014

In 50e2aad: Fixes #2981 Calling API.get in CronArchive. This will result in VisitFrequency.get being called therefore pre-processed as well.

@mattab
Copy link
Member Author

mattab commented Mar 17, 2014

In 11b8ef2: URL encoding the segment for consistency refs ##2981

@mattab
Copy link
Member Author

mattab commented Mar 17, 2014

In 1fd459b: Refs #2981 Fix display of visits in archive.php output

@mattab
Copy link
Member Author

mattab commented Jun 24, 2014

See follow up #5132 Goals & archiving settings

@mattab mattab added this to the 2.2.1 - Piwik 2.2.1 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
This was referenced May 24, 2012
Closed
Closed
Closed
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Fixes matomo-org#2981 Calling API.get in CronArchive. This will resul…
50e2aad 
…t in VisitFrequency.get being called therefore pre-processed as well.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
URL encoding the segment for consistency refs #matomo-org#2981
11b8ef2
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#2981 Fix display of visits in archive.php output
1fd459b
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
c: Performance For when we could improve the performance / speed of Matomo. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
2.2.1
Development

No branches or pull requests
1 participant
@mattab