-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
piwik.js: cross domain POST and automatically setRequestMethod('POST') when request > 2K #2321
Comments
(In [4483]) fixes #2321 |
setRequestMethod('POST') will only work when piwik server is on the same domain as the request, right? so vote for revert since otherwise it will break all tracking requests when piwik site is tracked on different domain as piwik server. |
(In [4486]) refs #2321 - revert r4483 |
Thanks - I think the proper solution involves some interesting magic such as POSTing to Iframes or cross posting xml http requests (none of which would work on all browsers so a combination of techniques is required) |
(In [4487]) refs #2321 - implement Cross-Origin Resource Sharing per W3C draft (supported by FF3.5, IE8, and latest versions of Safari and Chrome) |
(In [4492]) refs #2321 - fix unit test for feature freeze |
(In [4493]) refs #2321 - increase wait time on unit tests as tracking tests sometimes takes longer than expected |
(In [4503]) refs #2321 - fallback to getImage() if XDR fails |
Note: reverted [4487] in r6210 because Microsoft's implementation of XDR is broken (i.e., it doesn't follow the CORS spec). We might re-introduce it later, but would require browser detection. |
(In [6214]) refs #3112, refs #2321 - XMLHttpRequest Level 2 spec (draft) supports CORS; clean up comments
So, we won't restore support for IE's broken XDomainRequest, ever. (Tracker.php already implements the CORS response header.) |
We are tracking some pages with unicode text, so when it's encoded it's gets really long (each character is encoded to 4 characters). our get requests length is around 2500 which is way over the 2000 limit. Is there a solution ? I was thinking about using setCustomRequestProcessing and removing some parameters that we don't care about. |
I also got 414 (Request-URI Too Large) error when my event value is too long in trackEvent method. |
We welcome Pull requests 👍 http://developer.piwik.org/guides/contributing-to-piwik-core |
I might be working on this one |
* fixes #2321 when tracking request is > 2000 char, prefer POST * Fix jslint
GA starting doing this earlier this month.
We've had setRequestMethod() since Oct 2010, but this is an increasing necessity with the increase in size of tracking requests (e.g., attributeable to first party cookies and custom variables).
The text was updated successfully, but these errors were encountered: