Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP7.2 no longer supports 'object' as a class name in Sparkline #12065

Closed
Magentaize opened this issue Sep 16, 2017 · 3 comments
Closed

PHP7.2 no longer supports 'object' as a class name in Sparkline #12065

Magentaize opened this issue Sep 16, 2017 · 3 comments
Assignees
@Findus23
Milestone
3.2.0

Comments

@Magentaize
Copy link

Magentaize commented Sep 16, 2017 •
edited
Loading

In piwik/libs/sparkline/lib/Object.php, the class 'Object' should be renamed.
@Findus23
Copy link
Member

Hi, thanks for the info.

Maybe we should replace the library with one that isn't 14 years old and can be installed with composer.

e.g. https://github.com/davaxi/Sparkline
(even though it doesn't seem to support FeaturePoints (Minimum/Maximum))

@Findus23 Findus23 self-assigned this Sep 16, 2017
@Findus23 Findus23 mentioned this issue Sep 16, 2017
Merged
@mattab mattab added this to the 3.2.0 milestone Sep 18, 2017
@mattab mattab mentioned this issue Sep 18, 2017
Closed
@Findus23 Findus23 mentioned this issue Sep 20, 2017
Closed
@mattab mattab modified the milestones: 3.2.0, 3.1.2 Sep 21, 2017
@Findus23 Findus23 mentioned this issue Sep 21, 2017
Merged
@mattab
Copy link
Member

mattab commented Sep 25, 2017

fixed in #12099 duplicates #12086

@mattab mattab closed this as completed Sep 25, 2017
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Sep 25, 2017
@Findus23
Copy link
Member

@mattab, to be precise #12086 is a duplicate of this issue as it appeared later.

@Findus23 Findus23 removed the duplicate For issues that already existed in our issue tracker and were reported previously. label Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Findus23 Findus23

Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
3 participants
@mattab @Findus23 @Magentaize