we do request the available view datatables many times, eg when detec…

…ting the footerIcons. Instead cache the result to save many postEvents etc
matomo-org · Feb 2, 2015 · e349e24 · e349e24 · mattab · Feb 9, 2015
1 parent 478d539
commit e349e24
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/core/ViewDataTable/Manager.php b/core/ViewDataTable/Manager.php
@@ -8,6 +8,7 @@
  */
 namespace Piwik\ViewDataTable;
 
+use Piwik\Cache;
 use Piwik\Common;
 use Piwik\Option;
 use Piwik\Piwik;
@@ -63,6 +64,14 @@ public static function getIdsWithInheritance($klass)
      */
     public static function getAvailableViewDataTables()
     {
+        $cache = Cache::getTransientCache();
+        $cacheId = 'ViewDataTable.getAvailableViewDataTables';
+        $dataTables = $cache->fetch($cacheId);
+
+        if (!empty($dataTables)) {
+            return $dataTables;
+        }
+
         $klassToExtend = '\\Piwik\\Plugin\\ViewDataTable';
 
         /** @var string[] $visualizations */
@@ -107,6 +116,8 @@ public static function getAvailableViewDataTables()
             $result[$vizId] = $viz;
         }
 
+        $cache->save($cacheId, $result);
+
         return $result;
     }